php Compartilhar variáveis entre dois métodos

[Vinicius Cainelli 17]

Basicamente, o que eu tenho em uma classe são dois métodos.

- getEstablishment($establishmentId) que pega todos os dados de um determinado estabelecimento baseado no id passado.
- getAllEstablishments() que me da um array com todos os dados de todos os estabelecimentos que tenho no meu banco

Se repararem no código, vão ver que repete muitas variaveis, existe alguma forma de eu compartilha-lhas entre esses métodos?

 

  function getEstablishment($establishmentId)
  {
    $query = "SELECT *
      FROM establishment
      WHERE establishment_id='{$establishmentId}'
      LIMIT 0,1";
    $result = mysqli_query($this->connection, $query);
    $establishmentArray = mysqli_fetch_assoc($result);

    $docNumber = $establishmentArray['doc_number'];
    $legalName = $establishmentArray['legal_name'];
    $socialName = $establishmentArray['social_name'];
    $type = $establishmentArray['type_id'];
    $email = $establishmentArray['email'];
    $website = $establishmentArray['website'];
    $plan = $establishmentArray['plan_id'];
    $agreeTerm = $establishmentArray['agree_term'];
    $address = $establishmentArray['address'];
    $district = $establishmentArray['district'];
    $city = $establishmentArray['city_id'];
    $zipCode = $establishmentArray['postal_code'];
    $phone = $establishmentArray['phone'];
    $created = $establishmentArray['created'];
    $lastUpdate = $establishmentArray['last_update'];

    $establishment = new Establishment($docNumber, $legalName, $socialName, $type, $email, $website, $plan, $agreeTerm, $address, $district, $city, $zipCode, $phone, $created, $lastUpdate);

    return $establishment;
  }

  function getAllEstablishments()
  {
    $establishments = array();
    $query = "SELECT *
      FROM establishment
      ORDER BY establishment_id DESC";

    $result = mysqli_query($this->connection, $query);

    while ($establishmentArray = mysqli_fetch_assoc($result)) {

      $establishmentId = $establishmentArray['establishment_id'];
      $docNumber = $establishmentArray['doc_number'];
      $legalName = $establishmentArray['legal_name'];
      $socialName = $establishmentArray['social_name'];
      $type = $establishmentArray['type_id'];
      $email = $establishmentArray['email'];
      $website = $establishmentArray['website'];
      $plan = $establishmentArray['plan_id'];
      $agreeTerm = $establishmentArray['agree_term'];
      $address = $establishmentArray['address'];
      $district = $establishmentArray['district'];
      $city = $establishmentArray['city_id'];
      $zipCode = $establishmentArray['postal_code'];
      $phone = $establishmentArray['phone'];
      $created = $establishmentArray['created'];
      $lastUpdate = $establishmentArray['last_update'];

      $establishment = new Establishment($docNumber, $legalName, $socialName, $type, $email, $website, $plan, $agreeTerm, $address, $district, $city, $zipCode, $phone, $created, $lastUpdate);
      $establishment->setId($establishmentId);

      array_push($establishments, $establishment);
    }
    return $establishments;
  }

 

[srmacedo 66]

Em vez de variável usa propriedade...

[Gabriel Heming 766]

Se um trecho de código se repete, isole-o em um método:

function getEstablishment($establishmentId)
{
    $query = "SELECT *
    FROM establishment
    WHERE establishment_id='{$establishmentId}'
    LIMIT 0,1";
    $result = mysqli_query($this->connection, $query);        
    return $this->createObject(mysqli_fetch_assoc($result));
}

function getAllEstablishments()
{
    $establishments = array();
    $query = "SELECT *
    FROM establishment
    ORDER BY establishment_id DESC";

    $result = mysqli_query($this->connection, $query);

    while ($establishmentArray = mysqli_fetch_assoc($result)) {
        $establishments[] = $this->createObject($establishmentArray);
    }
    
    return $establishments;
}

private function createObject(array $rawEstablishment)
{
    $docNumber = $rawEstablishment['doc_number'];
    $legalName = $rawEstablishment['legal_name'];
    $socialName = $rawEstablishment['social_name'];
    $type = $rawEstablishment['type_id'];
    $email = $rawEstablishment['email'];
    $website = $rawEstablishment['website'];
    $plan = $rawEstablishment['plan_id'];
    $agreeTerm = $rawEstablishment['agree_term'];
    $address = $rawEstablishment['address'];
    $district = $rawEstablishment['district'];
    $city = $rawEstablishment['city_id'];
    $zipCode = $rawEstablishment['postal_code'];
    $phone = $rawEstablishment['phone'];
    $created = $rawEstablishment['created'];
    $lastUpdate = $rawEstablishment['last_update'];

    $establishment = new Establishment($docNumber, $legalName, $socialName, $type, $email, $website, $plan, $agreeTerm, $address, $district, $city, $zipCode, $phone, $created, $lastUpdate);
    $establishment->setId($rawEstablishment['establishment_id']);

    return $establishment;
}

 

Outra coisa que pode realizar é criar um método instrospect. Ou seja, deixar a responsabilidade para o próprio objeto Establishment:

class Establishment
{
    public function instrospect(array $raw)
    {
        $this->id = $raw['establishment_id']);
        $this->docNumber = $raw['doc_number'];
        $this->legalName = $raw['legal_name'];
        
        /** e demais inclusões **/
    }
}

Seus métodos, assim, serão simplificados:

function getEstablishment($establishmentId)
{
    $query = "SELECT *
    FROM establishment
    WHERE establishment_id='{$establishmentId}'
    LIMIT 0,1";

    $result = mysqli_query($this->connection, $query);

	$establishment = new Establishment();
    $establishment->instrospect(mysqli_fetch_assoc($result));

    return $establishment;
}

function getAllEstablishments()
{
    $establishments = array();
    $query = "SELECT *
    FROM establishment
    ORDER BY establishment_id DESC";

    $result = mysqli_query($this->connection, $query);

    while ($establishmentArray = mysqli_fetch_assoc($result)) {
        $establishment = new Establishment();
        $establishment->instrospect($establishmentArray);

        $establishments[] = $establishment;
    }
    
    return $establishments;
}

 

A propósito, sobre array_push:

Note: If you use array_push() to add one element to the array it's better to use $array[] = because in that way there is no overhead of calling a function.

Logo, substituí o seu array_push por:

$establishments[] = $this->createObject($establishmentArray);

 

[Vinicius Cainelli 17]

Boa, vou tentar dessa forma, obrigado.